View Issue Details

IDProjectCategoryView StatusLast Update
0001515K18X001.00 SKB SWANSWpublic2024-09-03 15:27
Reporter(ALTech) Sangmin Choi Assigned To(ALTech) Sangmin Choi Due Date2022-07-29 12:39
PriorityhighSeveritys4-minorReproducibilityalways
Status closedResolutionfixed 
Summary0001515: Google Assistant TTS message was not played under AAC channel.
DescriptionGoogle Assistant TTS message was not played under AAC channel.
Please check following reproduce step.

(You should test with TV which supports the AC3 audio)
1. Change the audio output to "External Device" refer to the attached document(Audio output setting.pdf)
2. Change the channel to AAC audio(number 10).
3. Press the GA button and ask "Weather", you can hear the TTS audio related with weather.
4. Change the channel to AC3 audio(number 11).
5. Press the GA button and ask "Weather", you can NOT hear the TTS audio related with weather.
-> It's ok until now
-> The live audio is set as AC3, so TTS audio can't be played because it's PCM audio.
6. Change the channel to AAC audio(number 10).
7. Press the GA button and ask "Weather", you can NOT hear the TTS audio related with weather.
-> This is the issue. GA TTS audio should be played under AAC channel.
-> If you didn't press the GA button under AC3 channel, this issue is not reproduced.
TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List (ALTech) Wooshin Kang , (SW) Jim Chen

Activities

(ALTech) Sangmin Choi

2022-07-26 11:49

developer  

Audio output setting.pdf (2,375,780 bytes)
GA_TTS_ExternalDevice.log (3,736,981 bytes)

(ALTech) Sangmin Choi

2022-07-26 11:50

developer   ~0010469

Hi, Jacky,

Please assign an engineer this issue.
FYI, the Eagle has no issue.

Thank you.

(SW) Jason Ling

2022-07-26 17:46

developer   ~0010472

Hi Sangmin,

Could you check this issue with Synaptics Tony directly.

We found this side effect from the following patch (patch.png) in folder vendor/synptics/vsxxx/audio

In your step3, Press GA key in AAC channel, the variable mFlushedFrames is 0, we can hear Google Assistant's response
In your step5, Press GA key in AC3 channel, the variable mFlushedFrames > 0, so the PCM data will be dropped. We can NOT hear Google Assistant's response
In your step7, Press GA key in AAC chanenl agin, It looks like the variable mFlushedFrames is not be reset to zero, => mFlushedFrames still > 0, so the PCM data will be dropped.

If we revert this patch, the problem goes away.

I think you can also refer BTVV-3709 (request-BTVV-3709.png)
This patch fixes BTVV-3709 and Wooshin asked us to apply it.

Thanks,
Jason
patch.jpg (350,731 bytes)
request-BTVV-3709.png (16,080 bytes)   
request-BTVV-3709.png (16,080 bytes)   

(ALTech) Sangmin Choi

2022-07-27 10:23

developer   ~0010474

Hi, Jason,

I reopened the BTVV-3709.
I will update when I get a feedback from Synaptics.

Thank you.

(ALTech) Sangmin Choi

2022-07-28 14:37

developer   ~0010481

Hi, Jason,

Synaptics Kail asked me to make Synaptics External Jira ticket for this issue.
You can check this issue at https://synacsm.atlassian.net/servicedesk/customer/portal/173/CSMSKBSBLT-190.

Thank you.

(ALTech) Sangmin Choi

2022-12-05 12:59

developer   ~0011392

Hi, Jason,

Synaptics fixed this issue and I tested it.

Could you please apply the following patches to UI 534 branches?
These patches are from Synpatics and you can see at https://synacsm.atlassian.net/servicedesk/customer/portal/173/CSMSKBSBLT-190.

1. revert below commit in vendor/synaptics/vsxxx
commit fd5ceac09d614f466f789c81bcb1cd3c0be902ff
Author: Tony Kim <Tony.Kim@synaptics.com>
Date: Wed Feb 16 21:57:35 2022 +0900

    Flush pcm from audioHal when HDMI is in RAW format

2. apply CSMAI2-55-Set-Property.patch to vendor/synaptics/vsxxx
3. apply CSMAI2-55-Add-Selinux.patch to vendor/synaptics/btv-hal-impl/bfx-ua300
4. apply CSMAI2-55-Ignore-AC3.patch to vendor/synaptics/btv-hal-impl/synaptics

Thank you.
CSMAI2-55-Set-Property.patch (1,338 bytes)   
commit c7b9a2987322324cc129a1382ebacc5b5b4870a7
Author: Sangmin Choi <smchoi@altech.kr>
Date:   Wed Nov 30 09:16:43 2022 +0900

    [BPM-9871] CSMAI2-55-Set-Property.patch

diff --git a/audio/audio_hw.cpp b/audio/audio_hw.cpp
index 7678423..89a8158 100755
--- a/audio/audio_hw.cpp
+++ b/audio/audio_hw.cpp
@@ -1209,6 +1209,9 @@ static int adev_set_parameters(struct audio_hw_device *dev,
 	if (ret >= 0) {
 		if (!strcmp(buf, "on")) {
 			MVLOGD("Set NUGU Playback on");
+            if( property_set("vendor.audio.nugu.enabled", "1") != 0 ) {
+                ALOGE("Failed to set vendor.audio.nugu.enable property");
+            }
 			//Fii add strat; For fix NUGU TTS jitter when BT connected and BTV live is playing; River 2022/07/17
 			if(gDevConStatus.a2dp_source_connected == true){
 				MVLOGD("Set BT Switch off");
@@ -1229,6 +1232,9 @@ static int adev_set_parameters(struct audio_hw_device *dev,
 		}
 		else if (!strcmp(buf, "off")){
 			MVLOGD("Set NUGU Playback off");
+            if( property_set("vendor.audio.nugu.enabled", "0") != 0 ) {
+                ALOGE("Failed to set vendor.audio.nugu.enable property");
+            }
 			//Fii add strat; For fix NUGU TTS jitter when BT connected and BTV live is playing; River 2022/07/17
 			if(gDevConStatus.a2dp_source_connected == true){
 				MVLOGD("Set BT Switch on");
CSMAI2-55-Set-Property.patch (1,338 bytes)   
CSMAI2-55-Add-Selinux.patch (514 bytes)   
commit 44d51539a95720c382bbc3b26a02149bd26f6bb4
Author: Sangmin Choi <smchoi@altech.kr>
Date:   Mon Nov 28 18:26:24 2022 +0900

    [BPM-9871] CSMAI2-55-Add-Selinux.patch

diff --git a/sepolicy/hal_btvservice.te b/sepolicy/hal_btvservice.te
index a0792e3..8ae1a5c 100644
--- a/sepolicy/hal_btvservice.te
+++ b/sepolicy/hal_btvservice.te
@@ -1 +1,4 @@
 #####
+allow btvservice_hal vendor_audio_prop:file open;
+allow btvservice_hal vendor_audio_prop:file read;
+allow btvservice_hal vendor_audio_prop:file getattr;
CSMAI2-55-Add-Selinux.patch (514 bytes)   
CSMAI2-55-Ignore-AC3.patch (2,499 bytes)   
commit 22677724e3437e9f9551d0281afbc7786c886265
Author: Sangmin Choi <smchoi@altech.kr>
Date:   Mon Nov 28 18:22:07 2022 +0900

    [BPM-9871] CSMAI2-55-Ignore-AC3.patch

diff --git a/amp_wrapper.c b/amp_wrapper.c
index 3e0b58a..0dc6bb6 100644
--- a/amp_wrapper.c
+++ b/amp_wrapper.c
@@ -4,6 +4,7 @@ extern "C" {
 
 #define LOG_TAG "halMediaPlayer"
 
+#include <stdio.h>
 #include <utils/Log.h>
 
 #include "btv_hal.h"
@@ -51,6 +52,21 @@ void amp_log(int device, char *log) {
 void amp_reset_buffer(synaptics_player_info *socPlayerInfo);
 INT64 amp_iptv_mgr_get_position(AVP_HANDLE *player);
 
+int amp_check_nugu_enabled(){
+    char nugu_enabled[PROP_VALUE_MAX];
+    memset(nugu_enabled, 0, PROP_VALUE_MAX);
+
+    if( !property_get("vendor.audio.nugu.enabled", nugu_enabled, "0") )
+        ALOGD("++%s failed to read vendor.audio.nugu.enabled", __FUNCTION__);
+
+    if( !strcmp(nugu_enabled, "1") ){
+        ALOGD("++%s nugu active (%s)!!!!", __FUNCTION__, nugu_enabled);
+        return 1;
+    }
+    ALOGD("++%s nugu in-active (%s)!!!!", __FUNCTION__, nugu_enabled);
+    return 0;
+}
+
 int amp_SetWindowSize(synaptics_player_info *socPlayerInfo) {
     ALOGD("++SetWindowSize");
     if(socPlayerInfo == NULL)  {
@@ -550,11 +566,16 @@ void setHdmiFormat(AMIXER_HANDLE amixer, AVP_AudioOutputMode mode) {
     HRESULT ret;
     if(mode == AVP_AUDIO_PASSTHROUGH /* && PREPARE_PASSTHROUGH&& socP8layerInfo->playerConfig.audio_codec == AMP_MS11_DDC*/) {
         if(spdifFormat != AMP_SND_SPDIF_FORMAT_RAW_MAIN || hdmiFormat != AMP_SND_HDMI_FORMAT_RAW_MAIN) {
-            ALOGD("++setHdmiFormat set dolby!!!!");
-            ret = AMP_SND_SetSpdifFormat(AMP_SND_SPDIF_FORMAT_RAW_MAIN);
-            assert(ret == SUCCESS);
-            ret = AMP_SND_SetHDMIFormat(AMP_SND_HDMI_FORMAT_RAW_MAIN);
-            assert(ret == SUCCESS);
+
+            if( amp_check_nugu_enabled() ){
+                ALOGD("++setHdmiFormat ignored nugu enabled!!!!");
+            }else{
+                ALOGD("++setHdmiFormat set dolby !!!!");
+                ret = AMP_SND_SetSpdifFormat(AMP_SND_SPDIF_FORMAT_RAW_MAIN);
+                assert(ret == SUCCESS);
+                ret = AMP_SND_SetHDMIFormat(AMP_SND_HDMI_FORMAT_RAW_MAIN);
+                assert(ret == SUCCESS);
+            }
         }else  ALOGD("++setHdmiFormat already dolby!!!");
     } else if(spdifFormat != AMP_SND_SPDIF_FORMAT_STEREO_PCM || hdmiFormat != AMP_SND_HDMI_FORMAT_PCM_MULTI) {
         ALOGD("++setHdmiFormat set pcm");
CSMAI2-55-Ignore-AC3.patch (2,499 bytes)   

(SW) Dean Chiang

2022-12-05 18:48

developer   ~0011397

Hi Sangmin,

Alredy apply the patches to UI 534 branches.

Thank you.

Issue History

Date Modified Username Field Change
2022-07-26 11:49 (ALTech) Sangmin Choi New Issue
2022-07-26 11:49 (ALTech) Sangmin Choi Status new => assigned
2022-07-26 11:49 (ALTech) Sangmin Choi Assigned To => (SW) Jacky Chiang
2022-07-26 11:49 (ALTech) Sangmin Choi File Added: Audio output setting.pdf
2022-07-26 11:49 (ALTech) Sangmin Choi File Added: GA_TTS_ExternalDevice.log
2022-07-26 11:50 (ALTech) Sangmin Choi Note Added: 0010469
2022-07-26 11:55 (ALTech) Sangmin Choi Issue Monitored: (ALTech) Wooshin Kang
2022-07-26 12:46 (SW) Jacky Chiang Assigned To (SW) Jacky Chiang => (SW) Jason Ling
2022-07-26 17:46 (SW) Jason Ling Note Added: 0010472
2022-07-26 17:46 (SW) Jason Ling File Added: patch.jpg
2022-07-26 17:46 (SW) Jason Ling File Added: request-BTVV-3709.png
2022-07-26 17:46 (SW) Jason Ling Assigned To (SW) Jason Ling => (ALTech) Sangmin Choi
2022-07-27 10:23 (ALTech) Sangmin Choi Note Added: 0010474
2022-07-28 14:37 (ALTech) Sangmin Choi Note Added: 0010481
2022-12-05 12:59 (ALTech) Sangmin Choi Note Added: 0011392
2022-12-05 12:59 (ALTech) Sangmin Choi File Added: CSMAI2-55-Set-Property.patch
2022-12-05 12:59 (ALTech) Sangmin Choi File Added: CSMAI2-55-Add-Selinux.patch
2022-12-05 12:59 (ALTech) Sangmin Choi File Added: CSMAI2-55-Ignore-AC3.patch
2022-12-05 12:59 (ALTech) Sangmin Choi Assigned To (ALTech) Sangmin Choi => (SW) Jason Ling
2022-12-05 17:35 (SW) Jason Ling Assigned To (SW) Jason Ling => (SW) Dean Chiang
2022-12-05 17:35 (SW) Jason Ling Issue Monitored: (SW) Jim Chen
2022-12-05 18:48 (SW) Dean Chiang Note Added: 0011397
2024-09-03 15:27 (ALTech) Sangmin Choi Assigned To (SW) Dean Chiang => (ALTech) Sangmin Choi
2024-09-03 15:27 (ALTech) Sangmin Choi Status assigned => closed
2024-09-03 15:27 (ALTech) Sangmin Choi Resolution open => fixed